enigma9o7
Crew Member
Posts: 1,427
Likes: 1,336
|
Post by enigma9o7 on Nov 23, 2021 6:16:56 GMT
Really not a big issue of course. And I imagine its cuz we're pushing all Moksha updates to bodhi 5 & 6. But, seems either need a different version for 5.x and 6.x, or need to make it do some smart stuff with variables to check the actual version.
(The problem is, "About Bodhi" says 6.0 on machine running 5.1).
|
|
|
Post by thewaiter on Nov 23, 2021 7:09:42 GMT
Yea, understand. It is still more and more harder to maintain both releases. We need to consider if drop BL 5.1 support or continue. It means more work for us. Mainly packaging work for Ylee. Not only Moksha but extra modules, 32 bit apps etc...
Discussion?
Stefan
|
|
enigma9o7
Crew Member
Posts: 1,427
Likes: 1,336
|
Post by enigma9o7 on Nov 23, 2021 8:29:18 GMT
I suggest don't tie moksha version to bodhi version. Cuz you can run latest Moksha on any currently supported bodhi version, right? At least as far as I know recently, moksha updated for bodhi 5 and 6....
When "about moksha" just need a moksha version separate from bodhi version.
|
|
|
Post by Hippytaff on Nov 23, 2021 9:23:54 GMT
Moksha can run on anything the version of EFL it uses can run on. Makes sense to maintain it separately though. It already has different version numbering to BL, would you need two separate moksha versions to display different BL version numbers? Seems like overkill for a version number.
|
|
|
Post by thewaiter on Nov 23, 2021 9:42:09 GMT
Apparently I did not explain it properly.
We have just one Moksha git repository with source code. The bodhi version is a part of e_bodhi_about.c file. So once again, if we build new package for BL 5.1 we do not change that version. It is that extra work we sorta ignore.
As you said not a big deal.
S
|
|
enigma9o7
Crew Member
Posts: 1,427
Likes: 1,336
|
Post by enigma9o7 on Nov 23, 2021 20:30:06 GMT
I do not believe the Bodhi version should be hard coded into Moksha. Moksha version, sure. But don't need separate git, just don't hard code Bodhi version into Moksha at all, instead check and report actual Bodhi version so when people select "About Bodhi" it should report Bodhi Version. When people select "About Moksha Dekstop" it should tell Moksha Version.
(I'm sure there are numerous ways to check bodhi version that dialog could use.... uname to check ubuntu/debian version, etc.)
|
|
|
Post by ylee on Nov 26, 2021 14:48:08 GMT
I will update moksha soon and this issue will be resolved.
|
|