|
|
Post by id2test on Mar 13, 2022 21:16:29 GMT
Hello, I often build Moksha from source, and have noticed that since commit Border: purge confusing noframe option the Engage module can no longer be loaded. As soon as the Engage module is loaded, the Moksha/Enlightenment process seem to crash and restart, and the Engage module does not get loaded. When I build from the previous commit, the Engage module loads and works fine again. This issue occurs on my desktop and in a virtual machine as well. In case I can help by providing some logs or other info please let me know. Thx. Regards, Ids.
|
|
|
|
Post by thewaiter on Mar 13, 2022 21:37:31 GMT
Hello and welcome It is my commit. Not sure how e_icon_image_object_set could be related to my border changes. The only idea is to follow changed config generation. Anyway, very surprising. I will look tomorrow... Stefan EDIT: OK, I built the previous commit and also the same bug. It can not be related. After some investigation, you apparently have the older engage package installed. What bodhi repo are you using? BL 5.1? For your test, can you build engage from source? github.com/JeffHoogland/moksha-modules-extra/tree/master/engage |
|
|
|
Post by id2test on Mar 14, 2022 7:39:57 GMT
Hello Stefan,
Thank you for looking in to this.
The Engage module is use was also built from the latest source on github.com/JeffHoogland/moksha-modules-extra/tree/master/engage
Ids
|
|
|
|
Post by thewaiter on Mar 14, 2022 12:07:50 GMT
OK, can you change one code line in engage source pls?
in
src/ng_gadgon.c
line 167
e_icon_object_set(it->o_proxy, o);
to
e_icon_edje_object_set(it->o_proxy, o);
and compile and install
thx
Stefan
|
|
|
|
Post by id2test on Mar 14, 2022 12:50:32 GMT
I made this modification to cat ng_gadcon.c
- e_icon_object_set(it->o_proxy, o); // Old API
+ e_icon_edje_object_set(it->o_proxy, o);
And did a build and install.
Unfortunately the problem is still there.
Ids.
|
|
|
|
Post by thewaiter on Mar 14, 2022 13:02:41 GMT
Can you join me on discord?
|
|
|
|
Post by id2test on Mar 15, 2022 18:37:02 GMT
I'm still trying to figure out why the engage module I built does not work with the updated Moksha, while your one does.
When I have more info I will let you know.
Thank you for all the help in Discord.
Ids
|
|
|
|
Post by thewaiter on Mar 15, 2022 19:19:41 GMT
After my investigation it looks like problem with package build dependences. Today I built moksha freh deb and engage fresh deb from source. All work fine. When I used engage from repository, it crashes. So my recommendationis to build both packages and install. I left my detailed info for ylee. I believe he will able to tell me more as he is the package maintainer. Stefan |
|
|
|
Post by thewaiter on Mar 16, 2022 18:19:41 GMT
id2testOK, after a chat with raster I made a commit to moksha code (I had to keep one variable in config structure). Please try to build moksha and engage now and let me know the feedback. Maybe erasing .e is recommended in case of troubles. Stefan
|
|
|
|
Post by id2test on Mar 16, 2022 19:28:54 GMT
Hi Stefan,
Thanks for the update.
I'll build moksha, and then engage against this new moksha, and test both.
And let you know after some testing what the result is.
Ids
|
|
|
|
Post by id2test on Mar 16, 2022 19:53:08 GMT
Hi Stefan,
I updated 2 different VMs with the latest moksha and engage packages built from source, did not touch .e, and engage loads without problems, also after a reboot.
So this combination seems all OK :-)
Thank you very much, and everybody else who helped.
Moksha rocks!
Regards,
Ids
|
|
